Make it build with ghc 9.10 #855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikd
requested review from
a team,
Jimbo4350,
newhoggy,
carbolymer,
smelc,
palas,
kevinhammond and
disassembler
as code owners
carbolymer
approved these changes
Aug 2, 2024
erikd
commented
Aug 2, 2024
cabal.project
Outdated
| , cardano-api:plutus-ledger-api | ||
| , cardano-api:prettyprinter-configurable | ||
| , cardano-api:base | ||
|
|
There was a problem hiding this comment.
I will let the node team decide whether the above needs to be fixed before this can be merged.
carbolymer
reviewed
Aug 2, 2024
erikd
force-pushed
the
erikd/ghc-9.10
branch
3 times, most recently
from
a374f02
to
ce4c19b
Compare
Also bumps the plutus-ledger-api version.
carbolymer
reviewed
Aug 9, 2024
| @@ -20,7 +20,7 @@ jobs: | |||
| strategy: | |||
| fail-fast: false | |||
| matrix: | |||
| ghc: ["9.6", "9.8"] | |||
| ghc: ["9.6", "9.8", "9.10"] | |||
There was a problem hiding this comment.
If our next GHC target after 8.10 is 9.6, I'm wondering if we need both 9.8 and 9.10 here?
carbolymer
approved these changes
Aug 9, 2024
Jimbo4350
approved these changes
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Checklist